Skip to content

Drop wheezy variant #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2018
Merged

Drop wheezy variant #567

merged 1 commit into from
May 11, 2018

Conversation

chorrell
Copy link
Contributor

@chorrell chorrell commented Nov 1, 2017

Full support for wheezy ended on April 26, 2016. LTS support will drop
in May 2018:

https://wiki.debian.org/DebianReleases#Production_Releases

We may want to wait until the LTS drop date. However, given the recent
release of Stretch the timing seems appropriate to do it sooner.

Also worth noting is that LTS is not supported by the Debian Security
team but by volunteers and interested companies:

https://wiki.debian.org/LTS

@chorrell
Copy link
Contributor Author

chorrell commented Feb 5, 2018

Ugh:

+ gpg --keyserver hkp://ha.pool.sks-keyservers.net:80 --recv-keys 94AE36675C464D64BAFA68DD7434390BDBE9B9C5
gpg: keyserver receive failed: Cannot assign requested address

LaurentGoderre

This comment was marked as off-topic.

@SimenB SimenB mentioned this pull request Apr 25, 2018
LaurentGoderre

This comment was marked as off-topic.

@LaurentGoderre
Copy link
Member

Please use Rebase and Merge when merging this.

@chorrell
Copy link
Contributor Author

Yeah, I wasn't done rebasing 😀

@LaurentGoderre
Copy link
Member

Can we merge this now since LTS EOL is less than a month away?

Full support for wheezy ended on April 26, 2016. LTS support will drop
in May 2018:

https://wiki.debian.org/DebianReleases#Production_Releases

We may want to wait until the LTS drop date. However, given the recent
release of Stretch the timing seems appropriate to do it sooner.

Also worth noting is that LTS is not supported by the Debian Security
team but by volunteers and interested companies:

https://wiki.debian.org/LTS
@chorrell
Copy link
Contributor Author

Yeah, once the test build passes. I just did another rebase.

@chorrell
Copy link
Contributor Author

This should be good to merge now

@LaurentGoderre LaurentGoderre merged commit 9a9e542 into nodejs:master May 11, 2018
@chorrell chorrell deleted the drop-wheezy branch May 11, 2018 14:21
@nodejs-github-bot
Copy link
Collaborator

Created PR to the official-images repo (docker-library/official-images#4345)

@chorrell
Copy link
Contributor Author

Something doesn't look right with the diff on the official PR:

https://github.com/docker-library/official-images/pull/4345/files

@LaurentGoderre What happened here? Did I miss a change somewhere?

https://github.com/docker-library/official-images/pull/4345/files#diff-02e54d9f9188e756a07463b72ae664a8R101

@LaurentGoderre
Copy link
Member

Hmmm well the positive thing is the PR finally works and also the PR logic did not touch the stackbrew library script. I will investigate that script to try and find out what caused it.

@chorrell
Copy link
Contributor Author

I'll leave the PR open, but note it should be ignored and then manually do another one.

@chorrell
Copy link
Contributor Author

Oh, I think I figured out what happened. It's including the locally checked out official-images repo because it has a Dockerfile, which passes the [ -f "$version/Dockerfile" ] || continue check.

See: https://github.com/docker-library/official-images/pull/4345/files#r187642847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants